[Cypress][EuiDataGrid] Fix locally failing test#8777
Merged
mgadewoll merged 1 commit intoelastic:mainfrom Jun 11, 2025
Merged
Conversation
- it looks like the call to getComputedStyle happens when the style is not updated yet, adding a wait() here returns expected behavior
mgadewoll
added
the
skip-changelog
Collaborator
💚 Build Succeededcc @mgadewoll |
Collaborator
💚 Build Succeeded
cc @mgadewoll |
20 tasks
acstll
approved these changes
Jun 11, 2025
Contributor
acstll
left a comment
acstll
left a comment
There was a problem hiding this comment.
Ran locally 3 times (a magic number), passed. Reverted, failed.
Thank you very much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
data_grid_cell.styles.spec.tsxcypress test which would fail when run locally only.It looks like the call to
getComputedStylethat gets the style information might happen too early. Adding await()resolves the issue.Note
The checks to styles should probably not happen in a cypress test as we're rather verifying functionality in those.
We should consider migrating those tests to VRT instead.
QA
Checkout this PR and run cypress tests locally in
eui/packages/eui:yarn test-cypress-devand choosedata_grid_cell.styles.spec.tsxto run.